fix(open-knowledge): launch OpenCode via --prompt, not positional#300
Merged
Conversation
…158) OpenCode's positional CLI arg is the project directory, so 'opencode <prompt>' made it try to cd into a directory named after the whole prompt (Error: Failed to change directory). The interactive TUI takes a starting prompt via --prompt, so the docked-terminal launch is now 'opencode --prompt <prompt>' (cwd is already the project). Added a promptFlag field to TerminalCliInfo for CLIs whose positional isn't the prompt; claude/codex/cursor unchanged. Updated buildCliLaunchCommand tests. GitOrigin-RevId: 1dd06d3304306689f5e6304ff2850eca69ef2e01
…(#2157) * feat(open-knowledge): faster, acceleration-respecting terminal scroll Tune the wheel scroll to match native terminals (Ghostty). The fix isn't a bigger flat multiplier — macOS bakes velocity acceleration into wheel deltas, and our per-event cap was clipping the accelerated fast-flick range. Keep a modest base multiplier and raise the cap so acceleration carries through: - mouse-mode accumulator: sensitivity 1 -> 1.5, maxRowsPerEvent 4 -> 20 (fast flicks travel far via OS acceleration; slow drags stay gentle) - normal scrollback: scrollSensitivity 3 (xterm default 1 felt sluggish) The DOM wiring test now pins the SGR payload shape rather than an exact tick count, so future feel-tuning doesn't break it. * chore(open-knowledge): changeset for terminal scroll tuning --------- GitOrigin-RevId: 3f65e266a4362f9008af1e9eee9c47283e90d972
Was clock-matched to the site's 7.8s cycle; as a focal README loop it reads too fast. Slow playback ~2x via frame delay 33ms->66ms (same frames, same 3.2MB). GitOrigin-RevId: 48ec87a2ad4da236c0291684e412a3a212df554f
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28211027612). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.